Merged
Conversation
ajeetj
requested review from
derekperkins,
dkhenry,
morgo and
sougou
as code owners
ajeetj
force-pushed
the
tal_test_rbr_default
branch
from
b81f4b7 to
030fc78
Compare
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
ajeetj
force-pushed
the
tal_test_rbr_default
branch
from
c04ac16 to
d9d6cb3
Compare
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
ajeetj
force-pushed
the
tal_test_rbr_default
branch
from
d9d6cb3 to
d5eab08
Compare
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Contributor
Author
|
@morgo Can you take a look at this when you get a chance?
|
Contributor
I'm not sure on these two. Perhaps @sougou will understand context. |
morgo
approved these changes
Jan 2, 2020
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5395
Default RBR for python tests
Reset to SBR wherever required for special testcases.
Removed
TestStatementReplicationWithRealDatabaseas it was failing to test statement based replication which is deprecated.Signed-off-by: Ajeet jain ajeet@planetscale.com